Re: devnull:I’m happy to roll back the changeI think, on balance, this may make sense.
-
Switching to my NodeBB account to continue the discussion.
The change has been rolled back now.
@trwnh@pixelfed.social when you say one shouldn't rely on
context.type
, why is that?When an object reports a
context
, I resolve it and check its' type to ensure it is Collection-ish.When someone on NodeBB tries to pull a context directly into NodeBB, I check for
context.type
(again, that it is Collection-ish) before trying to load posts.Both those checks seem ok. Admittedly someone could try pulling a followers collection in, but NodeBB would just see that they're not posts and find nothing to pull in.
So what's the problem? Ideally we have some sort of explicit declaration, of course.